Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gitian build instructions to v0.18.1.0 #8442

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

sethforprivacy
Copy link
Contributor

No description provided.

@hyc
Copy link
Collaborator

hyc commented Jul 18, 2022

Patch looks ok. I wonder if we should instead make the instructions to set a shell variable for the version instead, so we only need to update the doc in one place and just use the variable everywhere else?

VERSION=v0.18.0.0
./dockrun.sh $VERSION

etc...

@jeffro256
Copy link
Contributor

@hyc I think that's the better option and that's how it's done in the main gitian README

@sethforprivacy
Copy link
Contributor Author

Patch looks ok. I wonder if we should instead make the instructions to set a shell variable for the version instead, so we only need to update the doc in one place and just use the variable everywhere else?

VERSION=v0.18.0.0
./dockrun.sh $VERSION

etc...

Will make and push that change now, good suggestion.

Copy link
Contributor

@jeffro256 jeffro256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

contrib/gitian/DOCKRUN.md Outdated Show resolved Hide resolved
@sethforprivacy sethforprivacy changed the title Bump Gitian build instructions to v0.18.0.0 Bump Gitian build instructions to v0.18.1.0 Aug 9, 2022
@luigi1111 luigi1111 merged commit 5e2c851 into monero-project:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants